Re: [PATCH] Avoid allocating 0 bytes, was Re: [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc}
From: Eric Wong <hidden>
Date: 2016-06-15 22:42:15
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] Avoid allocating 0 bytes, was Re: [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] Avoid allocating 0 bytes, was Re: [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH] Avoid allocating 0 bytes, was Re: [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} · Johannes Schindelin <hidden>
Johannes Schindelin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/index-pack.c b/index-pack.c index d4ce3af..2927632 100644 --- a/index-pack.c +++ b/index-pack.c@@ -103,7 +103,7 @@ static void *unpack_entry_data(unsigned unsigned long pack_limit = pack_size - 20; unsigned long pos = *current_pos; z_stream stream; - void *buf = xmalloc(size); + void *buf = xmalloc(size ? size : 1); memset(&stream, 0, sizeof(stream)); stream.next_out = buf;
This is the only one I've managed to hit upon further use the past week of usage. No way to break out of the function, either, because current_pos needs to be updated (and it is changed despite a zero-byte blob object being in my repository). -- Eric Wong