Re: [PATCH] [COGITO] make cg-tag use git-check-ref-format

On Tuesday 13 December 2005 14:13, Junio C Hamano wrote:

Martin Atukunda [off-list ref] writes:

quoted

The egrep pattern used by cg-tag is too restrictive. While it will
prevent control characters from being specified as a tag name, it will
also reject nearly anything written in a non-English language, as noted
by -hpa ...
-(echo $name | egrep -qv '[^a-zA-Z0-9_.@!:-]') || \
+git-check-ref-format $name || \
 	die "name contains invalid characters"

Perhaps you meant to say:

	git-check-ref-format "$name"

Yes. i've just finished preparing a new patch with this exact change. But your 
patch is much better.

- Martin -

-- 
Due to a shortage of devoted followers, the production of great leaders has 
been discontinued.