[PATCH] use "git init-db" in tests
From: Alex Riesen <hidden>
Date: 2016-06-15 22:42:14
Subsystem:
the rest · Maintainer:
Linus Torvalds
Unless there was a special reason to use git-init-db from $PATH, could
the patch below be accepted? It makes the test suite use git-init-db
from the "the binaries we have just built".
The reason, why we need the patch even if the $PATH is set, will be
better explained by glibc's sources: the lookup does not stop if the
file exists but has no execute permission.
See file posix/execvp.c, the loop iterating over elements in $PATH:
switch (errno)
{
case EACCES:
/* Record the we got a `Permission denied' error. If we end
up finding no executable we can use, we want to diagnose
that we did find one but were denied access. */
got_eacces = true;
...
break;
...
}
...
/* We tried every element and none of them worked. */
if (got_eacces)
/* At least one failure was due to permissions, so report that
error. */
__set_errno (EACCES);
Signed-off-by: Alex Riesen <redacted>
---
By the same reason, the whole testsuite should be reviewed to use
"git <command>" notation.
t/test-lib.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
4417503d10870c913cff4f635acf274b7da75864diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0539dac..3704e5f 100755
--- a/t/test-lib.sh
+++ b/t/test-lib.sh@@ -190,8 +190,8 @@ test=trash rm -fr "$test" mkdir "$test" cd "$test" -git-init-db --template=../../templates/blt/ 2>/dev/null || -error "cannot run git-init-db" +git init-db --template=../../templates/blt/ 2>/dev/null || +error "cannot run git init-db" mv .git/hooks .git/hooks-disabled
--
0.99.9.GIT