Re: type_size_sort
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:14
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · type_size_sort · Morten Welinder <hidden>
- 2016-06-15 · Re: type_size_sort · Andreas Ericsson <hidden>
- 2016-06-15 · Re: type_size_sort · Junio C Hamano <hidden>
- 2016-06-15 · Re: type_size_sort · Morten Welinder <hidden>
- 2016-06-15 · Re: type_size_sort · Junio C Hamano <hidden>
Morten Welinder [off-list ref] writes:
static int type_size_sort(const struct object_entry *a, const struct
object_entry *b)
{
...
return a < b ? -1 : (a > b);
}
This does not look valid.Then something like this? ---
diff --git a/pack-objects.c b/pack-objects.c
index a62c9f8..c27fee5 100644
--- a/pack-objects.c
+++ b/pack-objects.c@@ -296,7 +296,7 @@ static int type_size_sort(const struct o return -1; if (a->size > b->size) return 1; - return a < b ? -1 : (a > b); + return memcmp(a->sha1, b->sha1, 20); } struct unpacked {