Thread (6 messages) flat view 6 messages, 2 authors, 2016-06-15

Re: [PATCH] Rename git-config-set to git-repo-config

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:42:13

Possibly related (same subject, not in this thread)

Hi,

On Thu, 24 Nov 2005, Junio C Hamano wrote:
Thanks for the patch.  I unfortunately was doing the same,
because I wanted to get the repo-format-validation stuff into a
presentable shape, and I thought this would interfere with it
and wanted to do it first (fortunately it didn't).  They are
both in the proposed updates branch.  At a quick glance, I think
your patch is identical to what I did (there aren't that many
different ways to rename a command after all).
Well, there are differences:

- I did not adjust the length of the "=====" line in the dox,

- I adjusted the punch line to "Get and set options in .git/config."
  (both in git-repo-config and git, but you have it in git, exchanged...), 
  and

- I did not rename the usage string in repo-config.c.
At least we should work on 5.6, if not 5.5.
Agree. I don't find too many bad things about

	open F, 'git-ls-files -z |' or die 'blabla';
I do not use git-mv myself.  It does not work in subdirectories,
and typing Documentation/ twice to move just one file is a
chore, so I tend to just 'R' (rename) the file, move to the
renamed file, and '!' (run shell command on the specified path)
with 'git-add', all within a single Emacs dired buffer.
Well, I don't use Emacs any longer, since it was such a hassle to install 
it on every machine. I still like it, though.

As for git-mv: looks like we need a "git-perl-setup.perl", right?
An option to git-format-patch _might_ make sense someday.  Maybe
after the world domination ;-).

Oh, wait.  It already can produce renaming patches, just does
not do it by default.

		Junio "again I forgot what I implemented before;
		sheesh I even used it myself to feed some patches
                to Linus" Hamano
*grin* Thanks for pointing that out, Oh Merciful Maintainer (OMM)!

Ciao,
Dscho "trying to find a place to put his flagellations which is hard in 
the absence of a last name in his typical signature"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help