Thread (1 message) 1 message, 1 author, 2016-06-15

Re: "make test" fails with current HEAD

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:12

Junio C Hamano [off-list ref] writes:
Linus Torvalds [off-list ref] writes:
quoted
Umm.. Why not just say "if the line after the 'diff' line doesn't start 
with '@@ ', then it's a binary diff"?
Thanks, that makes sense.
Maybe not; parse_single_patch would have eaten '@@ -' lines so
in practice that amounts to not checking anything at all.

Which is not a bad idea, though...  That means we would treat
all empty patches as binary diffs, which is certainly simple,
but is it safe enough?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help