Thread (1 message) 1 message, 1 author, 2016-06-15

Re: What's in git.git tonight

From: Paul Collins <hidden>
Date: 2016-06-15 22:42:10
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Junio C Hamano [off-list ref] writes:
merlyn@stonehenge.com (Randal L. Schwartz) writes:
quoted
And, I've confirmed that this patch does the trick, and will probably
defer any other issues with "optional" packages in the future:
Thanks.  Next time around could you sign-off your patch?
A tiny nit:

---

Consistency is the hobgoblin of small minds, and mine is tiny indeed.
Do not search the current directory when including expat.h, since it
is not supplied by git.

Signed-off-by: Paul Collins <redacted>
diff --git a/http-push.c b/http-push.c
index c10067c..89fda42 100644
--- a/http-push.c
+++ b/http-push.c
@@ -7,7 +7,7 @@
 
 #include <curl/curl.h>
 #include <curl/easy.h>
-#include "expat.h"
+#include <expat.h>
 
 static const char http_push_usage[] =
 "git-http-push [--complete] [--force] [--verbose] <url> <ref> [<ref>...]\n";

-- 
Dag vijandelijk luchtschip de huismeester is dood
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help