Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Do not send "want" lines for complete objects

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:09

Johannes Schindelin [off-list ref] writes:
Hi,
quoted
quoted
+		    ((o = parse_object(remote)) != NULL) &&
+		    (o->flags & COMPLETE) &&
I just realized that parse_object() always reads the file, then does a 
lookup (which makes the above code work), and then parses the file. It 
always does all of these steps, even if the object was already parsed. Any 
reason for this?
You are right.  We should be using lookup_object() for this part
of the code.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help