Re: [PATCH] Fix symbolic ref validation
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:08
Jonas Fonseca [off-list ref] writes:
quoted hunk
Yes, used rsync when I cloned. Seems validate_symref() was buggy.quoted
The other errors could also stem from the fact that quite a few places expect HEAD to be a symlink.git-reset still error out ... --- Use the correct buffer when validating 'ref: refs/...' Signed-off-by: Jonas Fonseca <redacted> ---diff --git a/refs.c b/refs.c
Thanks. One request, not just to Jonas. Please do not use '^---$' to separate the introductory discussion and the real commit log message. Linus style (recently the kernel list had a thread on this as well) is to have the commit log upfront with signoff, three-dash line, optional discussion and diffstat, and then diff. I do not mind seeing discussion upfront personally [*1*], but the thing is the tool treats everything after the first '^---$' something to be fed to patch, and does not treat it as the commit log message. [Footnote] *1* ...but remember, Linus does.