Thread (6 messages) 6 messages, 3 authors, 2016-06-15

Re: Honor extractor's umask in git-tar-tree.

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2016-06-15 22:42:07

Linus Torvalds wrote:
As to tar: I think the current

        if (S_ISDIR(mode) || S_ISREG(mode))
                mode |= (mode & 0100) ? 0777 : 0666;

is wrong. It makes things world-writable by default, and that's just dangerous.
That's standard in the Unix world, though; of course, the user's umask shouldn't be set to zero unless things are in very special circumstances.  In the case of tar, the umask is applied on extraction unless the user explicitly specifies -p.

	-hpa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help