Thread (1 message) 1 message, 1 author, 2016-06-15

Re: git 0.99.7b doesn't build on Cygwin

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:07

Linus Torvalds [off-list ref] writes:
Looking a bit closer at the diff() usage, I actually think that we could 
move the fork() closer to the exec - we'd just have to move it _into_ all 
the different cases (ie you'd have two different fork() calls: one for 
the "builtin" case, one for the external pgm case, but then the child in 
both cases would be very simple).
Looking back at what I did in the diff.c, I actually think the
part near fork() is a total crap ;-).

Originally I intended to do more work in the child process (this
is totally opposite of what is being proposed now), for example
running prepare_temp_file() after child forked, so that the
parent process does not have to worry about using memory for
expanded blob to be written out to the temporary file and then
later forgetting to free it ;-), but it seems the parent is
doing more work than I intended to.  I honestly think that the
part of the code is ancient enough to deserve a major facelift.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help