Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: StGIT cannot import properly from stdin

From: Pierre Ossman <hidden>
Date: 2016-06-15 22:42:07

Catalin Marinas wrote:
It works for me with the latest snapshot. What might happen in your
case is a missing "---" line after the patch description. The import
command reads the sys.stdin file descriptor until the first "---"
line. After that, the git.apply() function will read the rest of the
lines and pass them to git-apply. You can put some prints in the
git.apply() function to check where it starts reading from.

 
Hmm... it seems you're kind of right. It doesn't need the patch twice.
But it needs EOF more than once. The for-loop in __parse_patch() doesn't
start until the EOF is recieved. And the second for-loop in _input()
requires a new EOF.
Patches without description cannot be read from stdin at the moment.
Maybe I could add another option to prevent it from reading the
description.

 
If you would cache the input to a file (or memory) you would remove both
of these problems.

Rgds
Pierre
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help