Thread (12 messages) flat view 12 messages, 3 authors, 2016-06-15

Re: [PATCH 1/8] fetch.c: Remove useless lookup_object_type() call in process()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:07

Sergey Vlasov [off-list ref] writes:
In all places where process() is called except the one in pull() (which
is executed only once) the pointer to the object is already available,
so pass it as the argument to process() instead of sha1 and avoid an
unneeded call to lookup_object_type().
Agreed, except we probably would want to pass the expected type
to process() so that we can make sure the object is of that type,
perhaps?

Having said that, I am really happy that you seem to have fixed
it a lot better than my previous attempt, after which I was
really dissapointed that 'git clone' was still unusablly slow,
just walking commits in huge packs.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help