Thread (6 messages) flat view 6 messages, 3 authors, 2016-06-15

Re: [PATCH] Remove shell dependency in env.c

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2016-06-15 22:42:06

Junio C Hamano wrote:
"H. Peter Anvin" [off-list ref] writes:

quoted
This patch adds an invocation of "env", so rsh.c works for C-shell users 
as well as Bourne shell users.

Hmph.  I think the original code is buggy already.  If the path
has a single quote in it, you would get into a problem.  If the
remote end first interprets what is given to it with C-shell,
then it probably would also barf if path had a '!' in it, too,
even though we quote the entire thing within a single-quote
pair.
True.  The better method is to \-escape any questionable characters, 
instead of trying to use quotes.  I'll try to write that up.

	-hpa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help