Re: Status of Mac OS/X ports of git and cogito?

Hi,

On Sun, 11 Sep 2005, Linus Torvalds wrote:

On Sun, 11 Sep 2005, Junio C Hamano wrote:

quoted

Johannes Schindelin [off-list ref] writes:

quoted

I have three fixes in my personal tree without which git refuses to 
compile:

- daemon.c needs a define or typedef for socklen_t.

I still keep that patch around (the patch was end of July), but
have not touched it only because I did not hear from you asking
about its inclusion.

Side note: one simple solution for "socklen_t" is to just replace it with 
"int".

Any operating system where socklen_t is anything else than "int" is 
terminally broken. The people who introduced that typedef were confused, 
and I actually had to argue with them that it was fundamentally wrong: 
there is no other valid type than "int" that makes sense for it.

Linus, we all know that you are always right. Only that in this case you 
are just a little bit less right than usual. The introduction of this 
typedef was a sane thing to do, for the same reason it is a sane thing to 
use sensible variable names: documentation. It is _important_ that a 
program be easy to read for others. As a further candy, you can grep and 
even sed for socklen_t. Try that with every socklen_t substituted by int.

Ciao,
Dscho