Re: [PATCH] support older versions of libcurl
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:02
Subsystem:
the rest · Maintainer:
Linus Torvalds
Johannes Schindelin [off-list ref] writes:
Some newer features of libcurl are used which are not strictly necessary for http-pull. Use them only if libcurl is new enough to know about them.
Do you need to check against that many versions? Especially cleanup and init not depending on the same version number looks really suspicious. Assuming that the answer is still yes, how about doing things this way instead? ---
diff --git a/http-pull.c b/http-pull.c
--- a/http-pull.c
+++ b/http-pull.c@@ -6,6 +6,16 @@ #include <curl/curl.h> #include <curl/easy.h> +#if LIBCURL_VERSION_NUM < 0x070704 +#define curl_global_cleanup() do { /* nothing */ } while(0) +#endif +#if LIBCURL_VERSION_NUM < 0x070800 +#define curl_global_init(a) do { /* nothing */ } while(0) +#endif +#if LIBCURL_VERSION_NUM < 0x070907 +#define curl_easy_setopt(a, b, c) do { /* nothing */ } while(0) +#endif + static CURL *curl; static char *base;