Re: Is cogito really this inefficient
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:02
Linus Torvalds [off-list ref] writes:
On Thu, 14 Jul 2005, Linus Torvalds wrote:quoted
I'll look into making diff-cache be more efficient. I normally don't use it myself, so I didn't bother (I use git-diff-files, which is way more efficient, but doesn't show the difference against the _tree_, it shows the difference against the index. Since cogito tries to hide the index from you, cogito can't very well use that).Ok, done.
Wonderful.
Junio - I think this makes gitcore-pathspec pretty pointless, but I didn't actually remove it. I guess "git-diff-helper" still uses it.
And probably it shouldn't; diff-helper should be raw-to-patch converter, nothing more. Usually I'd volunteer to clean up the remaining mess (which was originally my mess anyway) myself, but since I'd already asked smurf to help cleaning up the diff option parsing, and recently I've suddenly got quite busy in the day job, so ...