On Tue, 28 Jun 2005, Linus Torvalds wrote:
On Wed, 29 Jun 2005, Nicolas Pitre wrote:
quoted
Of course by the time I sent the above you already rewrote the ting to
be streamable.
And by the time you sent me a new version, I'd already taken part of your
old one by hand ;)
Btw, I have the size/type bits reversed from your setup, but please don't
change that, since that would be yet another incompatible pack format
change, and I'd like to calm things down.
Also, I notice that you decode the sizes really strangely: you have a
"while() { }" loop and two separate loads. It's much nicer to do it with a
"do { } while()" loop and a single load, since not only is it less code,
a do-while loop compiles to better code than a while() loop (unless the
compiler is crazy, which it sometimes is).
Linus