Thread (8 messages) flat view 8 messages, 2 authors, 2016-06-15

Re: Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFS

From: Linus Torvalds <torvalds@osdl.org>
Date: 2016-06-15 22:41:58


On Sun, 22 May 2005, Thomas Glanzmann wrote:
While reading liblockfile I saw the following:
This is _really_ Linux-specific afaik. Which is ok for git, but at the
same time it really makes me go "Ewww". It's testing that the major number 
is 0, and it would be a lot more cleaner to use 

	if (!major(st.st_dev))

but even that is very Linux-specific.
[PATCH] Don't include device number in cache invalidation when running on NFS
I'll have to think about it. Maybe I should just remove the st_dev check. 
I guess inode/size/mtime/ctime should be plenty safe enough in practice.

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help