Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] The diff-raw format updates.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:41:58

I have to have some time to ruminate about this, but I am
leaving for the day and won't be back till late afternoon (PDT).

My feeling, knee-jerk reaction, to what you are proposing is
that you are trying to go half-way back to the earlier format
that had addremove/change distinction.

I have to disagree that having path for the non-existent side is
_illogical_.  I ask "what is different between tree A and tree
B", and the diff-raw answers "there was no path0 in tree A but
path0 exists in tree B; there was path1 in tree A but now path2
is there instead in tree B".  To me, the answer would be more
illogical if the diff-raw said "there was no /dev/null in tree
A, and instead path0 exists in tree B.", which is what your
suggestion makes it say if I am reading you right.  Also, again
this is my knee-jerk reaction without thinking things through,
you are hiding (not losing, because having a rename/copy entry
that removes a path _is_ illogical) information by not saying
what no longer exists by replacing the right hand side with
/dev/null and having the reader to infer what is removed.  I
want the reader to be able to say "I can look at only right hand
side to see what is in the right hand side tree".  With
/dev/null munging, it becomes necessary to sometimes look at the
other side.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help