Re: gitk-1.0 released

* Paul Mackerras [off-list ref] wrote:

quoted

- first window appearance on an uncached repository can be pretty slow 
  due to disk seeks - so it might make sense to display something (an 
  hourglass?) sooner - when i first started it i thought it hung. On 
  already cached repositories the window comes up immediately, and the 
  list of commits is updated dynamically.

The problem is that git-rev-tree HEAD doesn't output anything until it 
has read all the relevant commits, which can involve a lot of disk 
seeks.  I put the "Reading commits..." message in to indicate that 
something was happening, but your hourglass cursor suggestion is a 
good one.  It looks like git-rev-list might be better suited to what I 
want, actually.

it was quite a couple of seconds to get the empty windows with the 
'Reading commits...' message. It was this first period of time (5-10 
seconds?) which i mistook for a hang. Perhaps this is some Tk startup 
slowness, not a genuine gitk issue?

+	if {$nparents($id) > 2} {
+	    set xt [expr {$xt + ($nparents($id) - 2) * $linespc}]
+	}

thanks, this fix did the trick.

	Ingo