Re: [PATCH 0/1] Diff-helper update

quoted

quoted

quoted

quoted

"JCH" == Junio C Hamano [off-list ref] writes:

quoted

quoted

quoted

quoted

"LT" == Linus Torvalds [off-list ref] writes:

LT> On Wed, 18 May 2005, Junio C Hamano wrote:

quoted

quoted

I suspect doing something like this might be saner instead,
assuming non raw-diffs come at the end.  

LT> It won't ever trigger, since we only exit the loop once we see EOF.

JCH> I was not talking about correctness, but the readability of the
JCH> code.  Breaking out from the loop to process raw-diff and
JCH> switching to straight copy would make our intent more explicit.

I was completely mistaken about what you were talking about.
Your output (helper's input) is (<non-diff material>* <raw-diff
material>*)*, so of course we should not break out of the main
loop.