Re: git and symlinks as tracked content
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:41:56
quoted
quoted
quoted
quoted
"LT" == Linus Torvalds [off-list ref] writes:
LT> On Tue, 3 May 2005, Kay Sievers wrote:
quoted
Where can we store the link-target? In its own blob-object or directly in the tree-object?
LT> - directories: S_IFDIR (0040000) point to "tree" objects for contents LT> - symlinks: S_IFLNK (0120000) point to "blob" objects LT> - executables: S_IFREG | 0755 (0100755) point to "blob" objects LT> - regular files: S_IFREG | 0644 (0100644) point to "blob" objects These and the device nodes you mention would work naturally on the cache side and I generally like this idea. You need to update checkout-cache to (attempt to) create the right kind of file, but that is about it. On the diff side, things are a bit more interesting. Both the git-diff-tree-helper engine (diff.c) and git-apply-patch-script need to be told about these new types of objects, or at least tightened up to ignore them until they know how to support them. LT> When you think of it that way, the "patch" ends up falling out very LT> naturally, I think. It would look like LT> New file: filename (Mode: 0120000) LT> --- /dev/null LT> +++ filename LT> @@ 0,0 1,1 LT> +symlink-value LT> (or something, you get the idea). I've always wanted to have this from the normal "diff -r" output, but we have to be careful. You do not want to accidentally feed the normal patch that kind of output. How about doing something like this? GIT: filename (mode:120000) --- /dev/null +++ filename @@ -0,0 +1 @@ +symlink-value GIT: filename (mode:120000) --- filename +++ /dev/null @@ -1 +0,0 @@ -symlink-value GIT: filename (mode:120000->120000) --- filename +++ filename @@ -1 +1 @@ -old-symlink-value +new-symlink-value That is, to indent them to keep patch from noticing them [*1*]. About the device nodes, the diffed contents would be major and minor in decimal notation, and the real filesystem permission bits and ownerships (e.g. changing /dev/audio from 0600 to 0660 or from root:root to root:audio). I do not know if we would want owner/group in symbolic or numeric yet. GIT: filename (mode:0020000->0020000) --- dev/audio +++ dev/audio @@ -1,5 +1,5 @@ major=14 minor=4 owner=root -group=root -perm=0600 +group=audio +perm=0660 [Footnote] *1* A careful but not careful enough reader would wonder if the use of "--- /dev/null" or "+++ /dev/null" to represent an addition and a deletion may hamper managing the device node "/dev/null", but this is not a problem. Such a device node managed by GIT will appear as "--- dev/null" or "+++ dev/null", without the leading slash.