Thread (5 messages) flat view 5 messages, 4 authors, 2016-06-15

Re: [PATCH] Resurrect diff-tree-helper -R

From: Linus Torvalds <torvalds@osdl.org>
Date: 2016-06-15 22:41:55


On Sat, 30 Apr 2005, Junio C Hamano wrote:
Diff-tree-helper take two patch inadvertently dropped the
support of -R option
Talking about the diffs, I'm beginning to hate those "mode" things.

Not only do they screw up diffstat (big deal), but they are pointless, 
since 99.9% of the time the mode stays the same.

So it would be much nicer (I think) if mode changes are handled 
separately, with a simple separate line before the diff saying

	"Mode change: %o->%o %s", oldmode, newmode, path

and not mess up the diff header. That way, you only see it when it
actually makes any difference, and it's more readable both for humans
_and_ machines as a result.

Normal "patch" will just ignore the extra lines before the diff anyway, so 
it won't matter there.

Comments?

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help