Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: Trying to use AUTHOR_DATE

From: Edgar Toernig <hidden>
Date: 2016-06-15 22:41:55

tony.luck@intel.com wrote:
quoted
There was a time-parsing bug somewhere, where mktime() got invoked on a 
UTC date.  I proposed changing it to curl_gettime() instead.
Here's a patch to switch to using curl_getdate():
Another dependency :-(   I can live without http-pull but not
without commit-tree.

What's wrong with the patch I sent to fix this:

	http://marc.theaimsgroup.com/?m=111446501003389
+	/* find the timezone at the end */
+	p = date + strlen(date);
+	while (p > date && isdigit(*--p))
+		;
+	if ((*p == '+' || *p == '-') && strlen(p) == 5)
+		snprintf(result, maxlen, "%lu %5.5s", then, p);
This will choke on dates from Linus which have a trailing comment:

	Date: Fri, 29 Apr 2005 15:26:14 -0700 (PDT)

Ciao, ET.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help