Thread (4 messages) 4 messages, 3 authors, 2014-08-10

Re: [PATCH] checkpatch: Add test for commit id formatting style in commit log

flat view

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2014-08-10 21:33:22
Also in: lkml

On Sun, 10 Aug 2014 14:28:01 -0700 Joe Perches [off-list ref] wrote:
quoted
On Thu, Jul 3, 2014 at 12:00 AM, Joe Perches [off-list ref] wrote:
quoted
Commit logs have various forms of commit id references.

Try to standardize on a 12 character long lower case
commit id along with a description of parentheses and
the quoted subject line

ie: commit 0123456789ab ("commit description")
Now this is in mainline, checkpatch starts complaining about my "too long"
(40 chars) commit IDs in commit messages :-(

40 chars may be too long (but it's quick to copy-and-paste, as "git show"
shows that by default), but 12 sounds a bit short, as that's only 48 bits.
Right now, this test allows 12 to 16 byte length commit ids
without emitting a warning.

Andrew wanted this test, I don't care how long the commit id
is in the commit log.
Well, I mainly wanted to stop having to add "commit description" when
people forget it.  The length check was perhaps a bit anal.  How about
we make it "12 or more"?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help