Re: unable to resolve reference refs/tags/v3.1-rc8: Success (Re: git problem)

Hi,

Larry Finger wrote:

quoted

I had my system freeze when doing a pull from Linus's repo. Since then,
every pull results in the following errors:

~>  git pull
error: unable to resolve reference refs/tags/v3.1-rc8: Success
 From git://github.com/torvalds/linux
  ! [new tag]         v3.1-rc8   ->  v3.1-rc8  (unable to update local ref)

Could you try pulling again with
"/path/to/git/sources/bin-wrappers/git pull" after applying this
patch?

Thanks,

diff --git i/refs.c w/refs.c
index a615043b..b15f78a4 100644
--- i/refs.c
+++ w/refs.c

@@ -493,12 +493,15 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int *
  		char *buf;
  		int fd;

-		if (--depth<  0)
+		if (--depth<  0) {
+			errno = ELOOP;
  			return NULL;
+		}

  		git_snpath(path, sizeof(path), "%s", ref);
  		/* Special case: non-existing file. */
  		if (lstat(path,&st)<  0) {
+			int saved_errno = errno;
  			struct ref_list *list = get_packed_refs(NULL);
  			while (list) {
  				if (!strcmp(ref, list->name)) {

@@ -509,6 +512,7 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int *
  				}
  				list = list->next;
  			}
+			errno = saved_errno;
  			if (reading || errno != ENOENT)
  				return NULL;
  			hashclr(sha1);

@@ -562,7 +566,8 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int *
  			*flag |= REF_ISSYMREF;
  	}
  	if (len<  40 || get_sha1_hex(buffer, sha1))
-		return NULL;
+		die("ref %s is corrupt: length=%d, content=%.*s", ref,
+		    (int) len, (int) len, buffer);
  	return ref;
  }