Re: gitweb: kernel versions in the history (feature request, probably)

Kay Sievers wrote, On 11/21/2007 05:06 PM:

On Nov 21, 2007 8:52 AM, Jarek Poplawski [off-list ref] wrote:

quoted

On Tue, Nov 20, 2007 at 10:20:09PM -0500, J. Bruce Fields wrote:

quoted

On Wed, Nov 21, 2007 at 12:30:23AM +0100, Jarek Poplawski wrote:

quoted

I don't know git, but it seems, at least if done for web only, this
shouldn't be so 'heavy'. It could be a 'simple' translation of commit
date by querying a small database with kernel versions & dates.

If I create a commit in my linux working repo today, but Linus doesn't
merge it into his repository until after he releases 2.6.24, then my
commit will be created with an earlier date than 2.6.24, even though it
isn't included until 2.6.25.

So you have to actually examine the history graph to figure this out
this sort of thing.

Of course, you are right, and I probably miss something, but to be
sure we think about the same thing let's look at some example: so, I
open a page with current Linus' tree, go to something titled:
/pub/scm / linux/kernel/git/torvalds/linux-2.6.git / history

and see:
2007-10-10 Stephen Hemminger [NET]: Make NAPI polling independent ...
and just below something with 2007-08-14 date.

Accidentally, I can remember this patch introduced many changes, and
this big interval in dates suggests some waiting. Then I look at the
commit, and there are 2 dates visible, so the patch really was created
earlier. Then I go back to:
/pub/scm / linux/kernel/git/torvalds/linux-2.6.git / summary

and at the bottom I can see this:

...
tags
4 days ago      v2.6.24-rc3     Linux 2.6.24-rc3
2 weeks ago     v2.6.24-rc2     Linux 2.6.24-rc2
4 weeks ago     v2.6.24-rc1     Linux 2.6.24-rc1
6 weeks ago     v2.6.23         Linux 2.6.23

which drives me crazy, because, without looking at the calendar, and
calculator, I don't really know which month was 6 weeks ago, and 4
days ago, either!

So, I go to the: http://www.eu.kernel.org/pub/linux/kernel/v2.6/,
do some scrolling, look at this:
ChangeLog-2.6.23             09-Oct-2007 20:38  3.8M

and only now I can guess, this napi patch didn't manage to 2.6.23.
Of course, usually I've to do a few more clicks and reading to make
sure where it really started.

So, this could suggest this 2007-10-10 (probably stored with time
too), could be useful here... but it seems, I'm wrong.

Of course, this problem doesn't look so hard if we forget about
git internals: I can imagine keeping a simple database, which
could simply retrieve commit numbers from these ChangeLogs, and
connecting this with gitweb's commit page as well... For
performance reasons, doing it only for stable and testing, so with
-rc 'precision' would be very helpful too.

The "plain" view of the patch has the "version" included:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=bea3348eef27e6044b6161fd04c3152215f96411

  From: Stephen Hemminger [off-list ref]
  Date: Wed, 3 Oct 2007 23:41:36 +0000 (-0700)
  Subject: [NET]: Make NAPI polling independent of struct net_device objects.
  X-Git-Tag: v2.6.24-rc1~1454^2~841

Is that what you are looking for?

YeeeS!!! You are a genius with eagle's eyes!

I've suspected from the beginning something like this has to be
there... And I really tried to find this before sending this. But,
as a matter of fact I didn't even try this "plain" or rather "raw",
because I've somehow thought "raw" is just plain text, so the same
only without html tags!? So, now I know, and it's enough to me. But,
... maybe it should be on this "complex" page as well?

Thanks very much,
Jarek P.

PS: I hope eagles can see in English at least the same as in Polish,
and more than I can see in my dictionary now!