Thread (3 messages) 3 messages, 2 authors, 2021-03-26

Re: [PATCH v2] fstests: don't relay on /proc/partitions for device size

From: Damien Le Moal <hidden>
Date: 2021-03-26 07:47:08
Also in: linux-btrfs

On 2021/03/26 16:39, Johannes Thumshirn wrote:
quoted hunk ↗ jump to hunk
Non-partitionable devices, like zoned block devices, aren't showing up in in
/proc/partitions and therefore we cannot relay on it to get a device's
size.

Use blockdev --getsz to get the block device size.

Cc: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: Johannes Thumshirn <redacted>

---
Changes to v1:
- Use blockdev --getsz instead of sysfs (Nikolay/Damien)
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 1c814b9aabf1..40a9bfac31da 100644
--- a/common/rc
+++ b/common/rc
@@ -3778,7 +3778,7 @@ _get_available_space()
 # return device size in kb
 _get_device_size()
 {
-	grep -w `_short_dev $1` /proc/partitions | awk '{print $3}'
+	blockdev --getsz $1
That is 512B sectors unit... This should be KB, no ?
 }
 
 # Make sure we actually have dmesg checking set up.

-- 
Damien Le Moal
Western Digital Research
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help