Thread (46 messages) 46 messages, 5 authors, 2022-02-11

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

From: Mark Brown <broonie@kernel.org>
Date: 2022-02-09 13:43:30
Also in: linux-fbdev, linux-pwm, lkml

On Wed, Feb 09, 2022 at 10:03:10AM +0100, Javier Martinez Canillas wrote:
+	if (ssd130x->vbat_reg) {
+		ret = regulator_enable(ssd130x->vbat_reg);
+		if (ret) {
+			dev_err(dev, "Failed to enable VBAT: %d\n", ret);
+			return ret;
+		}
+	}
Unless the device supports power being physically omitted regulator
usage should not be optional, it's just more code and a recipie for poor
error handling.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help