[PATCH 31/62] net/octeontx: use kvargs numeric helpers
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2026-09-14 05:52:33
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
parse_integer_arg() uses atoi(), which cannot report an error, so a
malformed value such as "abc" becomes zero and the negative check never
fires.
It also stores through an int pointer, while the caller passes
¶ms->nr_port, which is a uint8_t and the only member of a
struct octeontx_vdev_init_params on the stack. Parsing nr_port
therefore wrote three bytes past the field.
Use rte_kvargs_handle_u8(), which both validates the value and matches
the width of the field.
Bugzilla ID: 2036
Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/octeontx/octeontx_ethdev.c | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index e4dca30d9d..d2ad9a7d04 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c@@ -65,22 +65,6 @@ RTE_LOG_REGISTER_SUFFIX(otx_net_logtype_mbox, mbox, NOTICE); RTE_LOG_REGISTER_SUFFIX(otx_net_logtype_init, init, NOTICE); RTE_LOG_REGISTER_SUFFIX(otx_net_logtype_driver, driver, NOTICE); -/* Parse integer from integer argument */ -static int -parse_integer_arg(const char *key __rte_unused, - const char *value, void *extra_args) -{ - int *i = (int *)extra_args; - - *i = atoi(value); - if (*i < 0) { - octeontx_log_err("argument has to be positive."); - return -1; - } - - return 0; -} - static int octeontx_parse_vdev_init_params(struct octeontx_vdev_init_params *params, struct rte_vdev_device *dev)
@@ -106,7 +90,7 @@ octeontx_parse_vdev_init_params(struct octeontx_vdev_init_params *params, ret = rte_kvargs_process(kvlist, OCTEONTX_VDEV_NR_PORT_ARG, - &parse_integer_arg, + rte_kvargs_handle_u8, ¶ms->nr_port); if (ret < 0) goto free_kvlist;
--
2.53.0