Thread (3 messages) 3 messages, 2 authors, 27d ago

[PATCH] eal: fix pointer add/sub macros for large offsets values

flat view
COLD27d

From: Bruce Richardson <hidden>
Date: 2026-09-11 16:40:38
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

The macros for adding or subtracting from pointers cast the pointer type
to uintptr_t before doing the arithmetic. However, for 32-bit builds, if
the value being added or subtracted is larger than uintptr_t, then we
get errors when casting back to "void *" type. We fix this by casting
the result to uintptr_t before casting to pointer.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <redacted>
---
 lib/eal/include/rte_common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index f872d3eabb..c17f50e2fd 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -572,12 +572,12 @@ static void __attribute__((destructor(RTE_PRIO(prio)), used)) func(void)
 /**
  * add a byte-value offset to a pointer
  */
-#define RTE_PTR_ADD(ptr, x) ((void*)((uintptr_t)(ptr) + (x)))
+#define RTE_PTR_ADD(ptr, x) ((void *)(uintptr_t)((uintptr_t)(ptr) + (x)))
 
 /**
  * subtract a byte-value offset from a pointer
  */
-#define RTE_PTR_SUB(ptr, x) ((void *)((uintptr_t)(ptr) - (x)))
+#define RTE_PTR_SUB(ptr, x) ((void *)(uintptr_t)((uintptr_t)(ptr) - (x)))
 
 /**
  * get the difference between two pointer values, i.e. how far apart
-- 
2.53.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help