Thread (169 messages) 169 messages, 10 authors, 19d ago

RE: [PATCH 26/61] net/enic: replace use of rte_memcpy

From: Hyong Youb Kim (hyonkim) <hidden>
Date: 2026-08-20 09:05:52

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Sent: Thursday, August 20, 2026 2:12 PM
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>; John Daley
(johndale) [off-list ref]; Hyong Youb Kim (hyonkim)
[off-list ref]
Subject: [PATCH 26/61] net/enic: replace use of rte_memcpy

Don't need rte_memcpy for fixed size value.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/enic/enic_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 2696fa77d4..59a557a38e 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1215,8 +1215,8 @@ static int enic_set_rsskey(struct enic *enic, uint8_t
*user_key)

 	/* Save for later queries */
 	if (!err) {
-		rte_memcpy(&enic->rss_key, rss_key_buf_va,
-			   sizeof(union vnic_rss_key));
+		memcpy(&enic->rss_key, rss_key_buf_va,
+		       sizeof(union vnic_rss_key));
 	}
 	enic_free_consistent(enic, sizeof(union vnic_rss_key),
 		rss_key_buf_va, rss_key_buf_pa);
@@ -1248,7 +1248,7 @@ int enic_set_rss_reta(struct enic *enic, union
vnic_rss_cpu *rss_cpu)

 	/* Save for later queries */
 	if (!err)
-		rte_memcpy(&enic->rss_cpu, rss_cpu, sizeof(union
vnic_rss_cpu));
+		memcpy(&enic->rss_cpu, rss_cpu, sizeof(union vnic_rss_cpu));
 	return err;
 }

--
2.53.0
Acked-by: Hyong Youb Kim <redacted>

Thanks.
-Hyong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help