[RFC v2 1/3] vdpa/mlx5: fix check on err interrupt FD
From: David Marchand <hidden>
Date: 2026-07-27 11:53:28
Subsystem:
mellanox mlx5 vdpa driver, the rest, virtio core · Maintainers:
Dragos Tatulea, Linus Torvalds, "Michael S. Tsirkin", Jason Wang
A 0 file descriptor is valid.
Prefer setting to -1 to indicate an invalid FD.
Fixes: 0474419bae7c ("vdpa/mlx5: handle hardware error")
Signed-off-by: David Marchand <redacted>
---
drivers/vdpa/mlx5/mlx5_vdpa_event.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
index 43585a94b2..dee2ccc23d 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c@@ -452,7 +452,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv *priv) mlx5_vdpa_err_interrupt_handler, priv); if (ret != 0) { - rte_intr_fd_set(priv->err_intr_handle, 0); + rte_intr_fd_set(priv->err_intr_handle, -1); DRV_LOG(ERR, "Failed to register error interrupt for device %d.", priv->vid); rte_errno = -ret;
@@ -473,7 +473,7 @@ mlx5_vdpa_err_event_unset(struct mlx5_vdpa_priv *priv) int retries = MLX5_VDPA_INTR_RETRIES; int ret = -EAGAIN; - if (!rte_intr_fd_get(priv->err_intr_handle)) + if (rte_intr_fd_get(priv->err_intr_handle) < 0) return; while (retries-- && ret == -EAGAIN) { ret = rte_intr_callback_unregister(priv->err_intr_handle,
@@ -487,6 +487,7 @@ mlx5_vdpa_err_event_unset(struct mlx5_vdpa_priv *priv) rte_pause(); } } + rte_intr_fd_set(priv->err_intr_handle, -1); if (priv->err_chnl) { #ifdef HAVE_IBV_DEVX_EVENT union {
--
2.54.0