RE: [EXTERNAL] [PATCH] examples/fips_validation: fix dangling pointer for SHA test
From: Finn, Emma <hidden>
Date: 2025-08-29 10:40:56
-----Original Message----- From: Gowrishankar Muthukrishnan <redacted> Sent: Friday 29 August 2025 11:23 To: Finn, Emma <redacted> Cc: dev@dpdk.org; Ji, Kai <redacted> Subject: RE: [EXTERNAL] [PATCH] examples/fips_validation: fix dangling pointer for SHA test Importance: Highquoted
quoted
quoted
rte_free(vec.pt.val); - + vec.pt.val = NULL;Same could be the case for fips_mct_shake_test also.Good catch, probably the same could happen with shake. I currently don’t have a way to test shake but I'm happy to make the change as part of this patch if you can test?Did you find any segfault and so got to know the problem ? If so, what was the command you executed ?. Thanks, Gowrishankar
Running fips sample app with aesni_mb and SHA ACVP test vector files. Also occurs with QAT. ./dpdk-fips_validation --vdev=crypto_aesni_mb -- --req-file $FIPS_DIR/$alg/req --rsp-file $FIPS_DIR/$alg/resp_aesni_mb --path-is-folder Output shows invalid memory bug. EAL: Detected CPU lcores: 64 EAL: Detected NUMA nodes: 2 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: VFIO support initialized EAL: Using IOMMU type 1 (Type 1) CRYPTODEV: Creating cryptodev crypto_aesni_mb CRYPTODEV: Initialisation parameters - name: crypto_aesni_mb,socket id: 0, max queue pairs: 8 IPSEC_MB: ipsec_mb_create() line 168: IPSec Multi-buffer library version used: 2.0.0 EAL: Error: Invalid memory SHAKE is not supported by these hence I did not catch it. Thanks, Emma