RE: [EXTERNAL] Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix lock availability
From: Rakesh Kudurumalla <hidden>
Date: 2024-08-08 11:41:47
From: Thomas Monjalon <redacted> Sent: Tuesday, July 30, 2024 9:42 PM To: Rakesh Kudurumalla <redacted> Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; orika@nvidia.com; dev@dpdk.org; Jerin Jacob <redacted>; Nithin Kumar Dabilpuram <redacted>; stable@dpdk.org Subject: [EXTERNAL] Re: [PATCH v3 1/1] examples/l2fwd-jobstats: fix lock availability Hello, 30/07/2024 12: 03, Rakesh Kudurumalla: > This patch addresses the issue by introducing a delay Please start with describing the issue. > before acquiring the lock in the loop. This delay allows for better > availability of the Hello, 30/07/2024 12:03, Rakesh Kudurumalla:
This patch addresses the issue by introducing a delay
Please start with describing the issue.
before acquiring the lock in the loop. This delay allows for better
availability of the lock, ensuring that show_lcore_stats() can
periodically update the statistics even when forwarding jobs are running.
Why a delay is better than a pause? due to high frequency of polling in l2fwd_main_loop() rte_pause() is not yieding the processor to display stats relating to fwd and flush execution time so added a delay achieve the same.
quoted hunk ↗ jump to hunk
@@ -542,7 +542,7 @@ l2fwd_main_loop(void)
} while (likely(stats_read_pending == 0));
rte_spinlock_unlock(&qconf->lock);
- rte_pause();
+ rte_delay_us(10);
}