Thread (167 messages) 167 messages, 9 authors, 2022-10-10

Re: [PATCH v6 7/7] bbdev: remove unnecessary if-check

From: Maxime Coquelin <hidden>
Date: 2022-08-26 19:52:16


On 8/25/22 20:24, Nicolas Chautru wrote:
quoted hunk ↗ jump to hunk
Code clean up due to if-check not required

Signed-off-by: Nicolas Chautru <redacted>
---
  lib/bbdev/rte_bbdev_op.h | 15 ++++-----------
  1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index afa1a71..386eed8 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -970,10 +970,8 @@ struct rte_mempool *
  
  	/* Get elements */
  	ret = rte_mempool_get_bulk(mempool, (void **)ops, num_ops);
-	if (unlikely(ret < 0))
-		return ret;
  
-	return 0;
+	return ret;
  }
  
  /**
@@ -1006,10 +1004,8 @@ struct rte_mempool *
  
  	/* Get elements */
  	ret = rte_mempool_get_bulk(mempool, (void **)ops, num_ops);
-	if (unlikely(ret < 0))
-		return ret;
  
-	return 0;
+	return ret;
  }
  
  /**
@@ -1035,17 +1031,14 @@ struct rte_mempool *
  	int ret;
  
  	/* Check type */
-	priv = (struct rte_bbdev_op_pool_private *)
-			rte_mempool_get_priv(mempool);
+	priv = (struct rte_bbdev_op_pool_private *) rte_mempool_get_priv(mempool);
  	if (unlikely(priv->type != RTE_BBDEV_OP_FFT))
  		return -EINVAL;
  
  	/* Get elements */
  	ret = rte_mempool_get_bulk(mempool, (void **)ops, num_ops);
-	if (unlikely(ret < 0))
-		return ret;
  
-	return 0;
+	return ret;
  }
  
  /**
Acked-by: Maxime Coquelin <redacted>

Thanks,
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help