Re: [PATCH v2 14/16] net/pfe: disable HW CRC stripping
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-12-27 17:49:21
On Mon, 27 Dec 2021 21:46:43 +0530 nipun.gupta@nxp.com wrote:
quoted hunk ↗ jump to hunk
@@ -422,8 +422,11 @@ pfe_eth_close(struct rte_eth_dev *dev) } static int -pfe_eth_configure(struct rte_eth_dev *dev __rte_unused) +pfe_eth_configure(struct rte_eth_dev *dev) { + if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) + PFE_PMD_ERR("PMD does not support KEEP_CRC offload"); + return 0; }
Why is this necessary? There is already a check for offload capabilities in rte_eth_dev_configure(). The device should report correct supported offloads instead.