Thread (7 messages) 7 messages, 2 authors, 2021-12-22

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/examples: fix build on FreeBSD

From: Bruce Richardson <hidden>
Date: 2021-12-22 15:23:50

On Wed, Nov 17, 2021 at 11:20:17AM +0100, Thomas Monjalon wrote:
01/10/2021 17:41, Bruce Richardson:
quoted
On Fri, Oct 01, 2021 at 05:36:51PM +0200, Thomas Monjalon wrote:
quoted
01/10/2021 17:15, Bruce Richardson:
quoted
On Fri, Oct 01, 2021 at 05:03:11PM +0200, Thomas Monjalon wrote:
quoted
15/09/2021 19:36, Bruce Richardson:
quoted
On FreeBSD, "find" does not support the "printf" flag, so we
need to use "gfind" from the "findutils" package.
It is one more dependency.  Shouldn't we avoid it by rewritting
the shell commands with loops?
Probably in the longer term, yes. If I get the chance, I'll try and
rewrite this script, but let's keep this patch in the queue in case
I don't get to in the 21.11 timeframe.
OK I can help with the shell tricks if needed.
Well, I was actually considering a rewrite in python for two reasons: *
easy FS scans using the "walk()" function * portability across OS's
[which is the main reason for the work after all]
Applied this patch for 21.11.
Following up on this thread, implemented an alternative fix for this issue
which does not use the extra findutils dependency[1]. I didn't rewrite the
script in python as was my original intent, but used basic shell commands
to work around the lack of printf support in find, leading to a simpler
fix.

/Bruce

[1] http://patches.dpdk.org/project/dpdk/patch/20211222151855.803916-1-bruce.richardson@intel.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help