RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

-----Original Message-----
From: Morten Brørup <redacted>
Sent: Tuesday, December 21, 2021 16:58
To: Wang, Haiyue <redacted>; stephend@silicom-usa.com; Lu, Wenzhuo <redacted>;
Changchun Ouyang [off-list ref]; Zhang, Helin [off-list ref]
Cc: dev@dpdk.org; Wang, Wen <redacted>; stable@dpdk.org
Subject: RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

quoted

From: Wang, Haiyue [mailto:haiyue.wang@intel.com]
Sent: Tuesday, 21 December 2021 02.15

quoted

-----Original Message-----
From: Stephen Douthit <redacted>
Sent: Tuesday, December 21, 2021 05:33

On 12/20/21 02:53, Wang, Haiyue wrote:

quoted

quoted

-----Original Message-----
From: Stephen Douthit <redacted>
Sent: Tuesday, December 7, 2021 06:19

Make sure an SFP is really a SFF-8472 device that supports the

optional

quoted

quoted

quoted

soft rate select feature before just blindly poking those I2C

registers.

quoted

quoted

quoted

Skip all I2C traffic if we know there's no SFP.

Fixes: f3430431aba ("ixgbe/base: add SFP+ dual-speed support")
Cc: stable@dpdk.org

Signed-off-by: Stephen Douthit <redacted>
---

quoted

Normally, DPDK keeps sync with this kind of release.

Working with the Linux kernel mainline drivers is good advice.

The official Intel Linux drivers seem to be ages behind the Kernel mainline, and they don't fully

No, the "ixgbe" drivers is updated on "7/8/2021".

https://www.intel.com/content/www/us/en/download/14302/14687/intel-network-adapter-driver-for-pcie-intel-10-gigabit-ethernet-network-connections-under-linux.html

support the C3000 NICs, so don’t waste any time there! We recently tried using the official Intel
Linux drivers for a C3338 based project (using Kernel 3.19 in 32 bit mode with x2APIC disabled), and
they didn't work at all. We ended up backporting the necessary changes from the kernel mainline
instead.

From Steve's response: 
     ME: "I guess this is just in C3000 reference board SDK ?"
     Steve: "It's the board covered by Intel Doc # 574437."

I check the doc "Last Updated: 11/07/2018".... It should be some kind of customer release, that's why
they are not in the official *open source* Linux driver, so keep your patch set as private.