RE: [PATCH 1/3] crypto/ipsec_mb: fix qp setup null pointer dereference

-----Original Message-----
From: Power, Ciara <redacted>
Sent: Friday, December 10, 2021 2:10 PM
To: dev@dpdk.org
Cc: stable@dpdk.org; Mcnamara, John <redacted>; Zhang,
Roy Fan [off-list ref]; Power, Ciara [off-list ref];
De Lara Guarch, Pablo [off-list ref]
Subject: [PATCH 1/3] crypto/ipsec_mb: fix qp setup null pointer dereference

When setting up a qp in a secondary process, the local qp pointer is set
to the stored device qp, configured by the primary process for that
device, but only if that device qp is not NULL.
If the device qp was not set up correctly by the primary process and has
a NULL value, the local qp variable stays at the default initialised
value, NULL. This causes a NULL pointer dereference later in the
function when using the qp value.

This is fixed by always setting the local qp to the value of the device
qp stored, and then checking if qp is NULL, returning an error if it is.

Coverity issue: 374382
Fixes: 72a169278a56 ("crypto/ipsec_mb: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Ciara Power <redacted>

Acked-by: Fan Zhang <redacted>