Thread (4 messages) 4 messages, 3 authors, 2021-11-26

Re: [PATCH] net/mlx5: fix devargs validation for multiclass probe

From: Thomas Monjalon <hidden>
Date: 2021-11-25 09:29:09

25/11/2021 07:16, michaelba@nvidia.com:
From: Michael Baum <redacted>

The mlx5_args function reads the devargs and checks if they are valid
for this driver and if not it returns an error.

This was normal behavior as long as all the devargs come to this driver,
but since it is possible to run several drivers together, the function
may return an error for another driver's devarg even though it is
completely valid.
In addition the function does not allow the user to know which of the
devargs he sent is incorrect, but returns an error without printing the
unknown devarg.

This patch eliminates the error return in the case of an unknown devarg,
and prints a warning for each such devarg specifically.

Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <redacted>
Acked-by: Matan Azrad <redacted>
---
 drivers/net/mlx5/mlx5.c | 68 ++++++-----------------------------------
 1 file changed, 9 insertions(+), 59 deletions(-)
It is quite a big patch.
How well it has been tested?
How critical it is to have in 21.11?

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help