Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools
From: Jerin Jacob <hidden>
Date: 2021-11-17 11:31:32
On Wed, Nov 17, 2021 at 4:56 PM Elena Agostini [off-list ref] wrote:
quoted
On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini [off-list ref] wrote:quoted
quoted
quoted
quoted
quoted
External email: Use caution opening links or attachmentsquoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
On Wed, 17 Nov 2021 03:04:59 +0000quoted
quoted
quoted
quoted
quoted
[off-list ref] wrote:quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
From: Elena Agostini <redacted>quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
This patch introduces GPU memory in testpmd through the gpudev library.quoted
quoted
quoted
quoted
quoted
quoted
Testpmd can be used for network benchmarks when using GPU memoryquoted
quoted
quoted
quoted
quoted
quoted
instead of regular CPU memory to send and receive packets.quoted
quoted
quoted
quoted
quoted
quoted
This option is currently limited to iofwd engine to ensurequoted
quoted
quoted
quoted
quoted
quoted
no workload is applied on packets not accessible from the CPU.quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
The options chose is --mbuf-size so buffer split feature acrossquoted
quoted
quoted
quoted
quoted
quoted
different mempools can be enabled.quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
Signed-off-by: Elena Agostini <redacted>quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
Won't this create a hard dependency of test-pmd on gpudev?quoted
quoted
quoted
quoted
quoted
I thought gpudev was supposed to be optionalquoted
quoted
quoted
quoted
quoted
quoted
quoted
quoted
Sure, let me submit another patch to make it optionalquoted
quoted
Why to add yet another compile time macro everywhere in testpmd andquoted
make hard to maintain?quoted
Adding iofwd kind of code is very simple to add test/test-gpudev andquoted
all GPU specific optionsquoted
can be added in test-gpudev. It also helps to review the patches asquoted
test cases focus onquoted
each device class.Test-gpudev is standalone unit test to ensure gpudev functions work correctly. In testpmd instead, there is a connection between gpudev and the network.
I understand that. We had the same case with eventdev, where it needs to work with network. Testpmd is already complicated, IMO, we should focus only ethdev test cases on testpmd, test-gpudev can use ethdev API to enable networking requirements for gpudev.