Re: [dpdk-dev] [PATCH v2] vhost: remove async dma map status
From: Ding, Xuan <hidden>
Date: 2021-10-30 13:46:56
Hi Maxime,
-----Original Message----- From: Maxime Coquelin <redacted> Sent: Friday, October 29, 2021 6:36 PM To: Ding, Xuan <redacted>; dev@dpdk.org; Xia, Chenbo [off-list ref] Cc: Hu, Jiayu <redacted>; Burakov, Anatoly [off-list ref] Subject: Re: [PATCH v2] vhost: remove async dma map status On 10/27/21 12:00, Xuan Ding wrote:quoted
Async dma map status flag was added to prevent the unnecessary unmap when DMA devices bound to kernel driver. This brings maintenance cost for a lot of code. This patch removes the dma map status by using rte_errno instead. This patch relies on the following patch to fix a partial unmap check in vfio unmapping API. [1] https://www.mail-archive.com/dev@dpdk.org/msg226464.html Cc: anatoly.burakov@intel.com Signed-off-by: Xuan Ding <redacted> --- v2: * Fix a typo in commit log. --- lib/vhost/vhost.h | 3 -- lib/vhost/vhost_user.c | 70 ++++++++---------------------------------- 2 files changed, 13 insertions(+), 60 deletions(-)Applied to dpdk-next-virtio/main with title fixed. Please run check-git-log script next time.
Thanks for your fix. I ran the script first but got no warning... I will be more careful to check the format next time. BTW, should the CC be removed in the commit log? Regards, Xuan
Thanks, Maxime