Re: [dpdk-dev] [PATCH] test-compress-perf: fix unused-but-set-variable error
From: David Marchand <hidden>
Date: 2021-10-29 18:57:34
On Fri, Oct 29, 2021 at 7:18 PM Jim Harris [off-list ref] wrote:
clang-13 rightfully complains that the total_deq_ops variable in cperf_cyclecount_op_setup is set but not used, since the final accumulated total_deq_ops results isn't used anywhere. So just remove the total_deq_ops variable.
Unused from the start:
Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool")
quoted hunk ↗ jump to hunk
Signed-off-by: Jim Harris <redacted> --- app/test-compress-perf/comp_perf_test_cyclecount.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c index 55559a7d5a..c875ddbdac 100644 --- a/app/test-compress-perf/comp_perf_test_cyclecount.c +++ b/app/test-compress-perf/comp_perf_test_cyclecount.c@@ -76,7 +76,6 @@ cperf_cyclecount_op_setup(struct rte_comp_op **ops, for (iter = 0; iter < num_iter; iter++) { uint32_t remaining_ops = mem->total_bufs; - uint32_t total_deq_ops = 0; uint32_t total_enq_ops = 0; uint16_t num_enq = 0; uint16_t num_deq = 0;@@ -136,7 +135,6 @@ cperf_cyclecount_op_setup(struct rte_comp_op **ops, /* instead of the real dequeue operation */ num_deq = num_ops; - total_deq_ops += num_deq; rte_mempool_put_bulk(mem->op_pool, (void **)ops, num_deq); } --2.32.0
Reviewed-by: David Marchand <redacted> -- David Marchand