On Fri, Oct 29, 2021 at 10:22 AM Ferruh Yigit [off-list ref] wrote:

On 10/26/2021 6:14 AM, Ajit Khaparde wrote:

quoted

Minor fixes are needed in the RTE_FLOW RSS action parser.
1. Update the comment in the parser to indicate rss level 1 implies
RSS on outer header.
2. RSS action will not be supported if level is > 1.
3. RSS action will not be supported if user or application specifies
MARK or COUNT action.
4. If RSS types is not specified i.e., is 0, the best effort RSS should
use IPV4 and IPV6 headers. Currently we are considering only IPV4.

Fixes: fe0bab7eb34e ("net/bnxt: enhance support for RSS action")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Acked-by: Somnath Kotur <redacted>

<...>

quoted

@@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
      }

      /* If RSS types is 0, use a best effort configuration */
-     types = rss->types ? rss->types : RTE_ETH_RSS_IPV4;
+     types = rss->types ? rss->types : ETH_RSS_IPV4 | ETH_RSS_IPV6;

We should keep the RTE_ prefix, updating in the next-net.

ACK. Thanks