Thread (3 messages) 3 messages, 2 authors, 2021-11-04

[dpdk-dev] [PATCH] eal: fix unused-but-set-variable error

From: Jim Harris <hidden>
Date: 2021-10-29 17:16:55
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

clang-13 rightfully complains that the total_mem
variable in eal_parse_socket_arg is set but not
used, since the final accumulated total_mem
result isn't used anywhere. So just remove the
total_mem variable.

Signed-off-by: Jim Harris <redacted>
---
 lib/eal/linux/eal.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 81fdebc6a0..60b4924838 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -562,7 +562,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
 	char * arg[RTE_MAX_NUMA_NODES];
 	char *end;
 	int arg_num, i, len;
-	uint64_t total_mem = 0;
 
 	len = strnlen(strval, SOCKET_MEM_STRLEN);
 	if (len == SOCKET_MEM_STRLEN) {
@@ -594,7 +593,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)
 				(arg[i][0] == '\0') || (end == NULL) || (*end != '\0'))
 			return -1;
 		val <<= 20;
-		total_mem += val;
 		socket_arg[i] = val;
 	}
 
-- 
2.32.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help