Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: move inline APIs into separate structure
From: Akhil Goyal <hidden>
Date: 2021-10-18 07:02:24
Hi Akhil,quoted
Move fastpath inline function pointers from rte_cryptodev into a separate structure accessed via a flat array. The intension is to make rte_cryptodev and related structures private to avoid future API/ABI breakages. Signed-off-by: Akhil Goyal <redacted> --- lib/cryptodev/cryptodev_pmd.c | 51 ++++++++++++++++++++++++++++++ lib/cryptodev/cryptodev_pmd.h | 11 +++++++ lib/cryptodev/rte_cryptodev.c | 29 +++++++++++++++++ lib/cryptodev/rte_cryptodev_core.h | 29 +++++++++++++++++ lib/cryptodev/version.map | 5 +++ 5 files changed, 125 insertions(+)diff --git a/lib/cryptodev/cryptodev_pmd.cb/lib/cryptodev/cryptodev_pmd.c index 44a70ecb35..4646708045 100644--- a/lib/cryptodev/cryptodev_pmd.c +++ b/lib/cryptodev/cryptodev_pmd.c@@ -4,6 +4,7 @@ #include <sys/queue.h> +#include <rte_errno.h> #include <rte_string_fns.h> #include <rte_malloc.h>@@ -160,3 +161,53 @@ rte_cryptodev_pmd_destroy(struct rte_cryptodev*cryptodev)When a device is removed - aka when rte_pci_remove() is called cryptodev_fp_ops_reset() will never be called. This may expose a problem. Looks like cryptodev_fp_ops_reset() needs to be called here too.
rte_cryptodev_pmd_destroy internally calls rte_cryptodev_pmd_release_device and reset is called in that.