Re: [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath
From: Ivan Malov <hidden>
Date: 2021-10-12 19:48:37
Hi Ferruh, I apologise: there was a defect in v6. I re-submitted the series (v7): https://patches.dpdk.org/project/dpdk/list/?series=19571 Thank you. On 12/10/2021 21:08, Ferruh Yigit wrote:
quoted hunk ↗ jump to hunk
On 10/5/2021 4:56 PM, Ivan Malov wrote:quoted
Detect the flag in Rx prefix and pass it to users. Signed-off-by: Ivan Malov <redacted> Reviewed-by: Andrew Rybchenko <redacted> Reviewed-by: Andy Moreton <redacted><...>quoted
@@ -407,6 +409,15 @@ sfc_ef100_rx_prefix_to_offloads(const structsfc_ef100_rxq *rxq, ESF_GZ_RX_PREFIX_RSS_HASH); } + if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { + uint32_t user_flag; + + user_flag = EFX_OWORD_FIELD(rx_prefix[0], + ESF_GZ_RX_PREFIX_USER_FLAG); + if (user_flag != 0) + ol_flags |= PKT_RX_FDIR; + } +Hi Ivan, This cause a build error after another sfc patch merged into next-net [1]. Following change [2] seems fixing the issue, but to be sure nothing is missed can you please send a new version rebasing on top of latest next-net? [1] Commit d86c6ced8732 ("net/sfc: use xword type for EF100 Rx prefix") [2]diff --git a/drivers/net/sfc/sfc_ef100_rx.cb/drivers/net/sfc/sfc_ef100_rx.c index 704c62c0ac90..8237b772f151 100644--- a/drivers/net/sfc/sfc_ef100_rx.c +++ b/drivers/net/sfc/sfc_ef100_rx.c@@ -415,7 +415,7 @@ sfc_ef100_rx_prefix_to_offloads(const structsfc_ef100_rxq *rxq, if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { uint32_t user_flag; - user_flag = EFX_OWORD_FIELD(rx_prefix[0], + user_flag = EFX_XWORD_FIELD(rx_prefix[0], ESF_GZ_RX_PREFIX_USER_FLAG); if (user_flag != 0) ol_flags |= PKT_RX_FDIR;
-- Ivan M