Re: [dpdk-dev] [PATCH v7 3/5] telemetry: use unique socket paths for in-memory mode
From: Power, Ciara <hidden>
Date: 2021-10-12 15:47:41
-----Original Message----- From: Richardson, Bruce <redacted> Sent: Tuesday 12 October 2021 16:41 To: Power, Ciara <redacted> Cc: dev@dpdk.org; David Marchand <redacted>; Burakov, Anatoly [off-list ref]; Kevin Traynor [off-list ref] Subject: Re: [PATCH v7 3/5] telemetry: use unique socket paths for in- memory mode On Tue, Oct 12, 2021 at 04:37:07PM +0100, Power, Ciara wrote:quoted
Hi Bruce,quoted
-----Original Message----- From: Richardson, Bruce <redacted> Sent: Friday 8 October 2021 18:19 To: dev@dpdk.org Cc: Power, Ciara <redacted>; David Marchand [off-list ref]; Burakov, Anatoly [off-list ref]; Kevin Traynor [off-list ref]; Richardson, Bruce [off-list ref] Subject: [PATCH v7 3/5] telemetry: use unique socket paths for in-memory mode When running in in-memory mode, multiple processes can use the same runtime dir, leading to conflicts with the telemetry sockets in thatdirectory.quoted
quoted
We can resolve this by appending a suffix to each socket beyond the first, with the suffix being an increasing counter value. Each process uses the first unused socket counter value. Signed-off-by: Bruce Richardson <redacted> ---<snip> Thanks, Acked-by: Ciara Power <redacted>Thanks. I'm actually in two minds as to whether to this patch should be merged with the previous one. It was already reviewed and acked as a bugfix, but this patch also affects a lot of the same areas of code. What do you think? /Bruce
Yes, I was actually wondering about that myself. I think it would make more sense to merge them, rather than adding some code in patch 2 that then gets removed in patch 3. Thanks, Ciara